Implement process.name #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: docs/_docs/user-guide/eldritch.md modified: implants/lib/eldritch/src/process/name_impl.rs
hulto
requested changes
Oct 24, 2023
|
windows workflow failing in actions but passes in my lab. made some changes which i hope will clear this time |
KCarretto
reviewed
Oct 25, 2023
Codecov Report
@@ Coverage Diff @@
## main #332 +/- ##
==========================================
+ Coverage 75.06% 75.17% +0.11%
==========================================
Files 100 100
Lines 6545 6591 +46
==========================================
+ Hits 4913 4955 +42
- Misses 1545 1549 +4
Partials 87 87
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Looks good! Go ahead and sqaush and merge. |
hulto
approved these changes
Oct 26, 2023
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind eldritch-function
What this PR does / why we need it:
Implement process.name as per #58
Which issue(s) this PR fixes:
Fixes #58