Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cp/output log #319

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Cp/output log #319

merged 2 commits into from
Oct 12, 2023

Conversation

cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Oct 12, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Added a favicon
  • Changed title of application
  • Changed nav items to show which page is active
  • Added page to show a list of output
  • Added filtering to output
  • Added initial empty state components

Screenshots

Screenshot 2023-10-11 at 11 23 50 PM Screenshot 2023-10-11 at 11 24 35 PM

@cmp5987 cmp5987 requested a review from hulto October 12, 2023 03:23
hulto
hulto approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 - IDK @cmp5987 I really like having it say "React App" I guess we'll let it slide this time.

@cmp5987 cmp5987 merged commit 3f3c68c into main Oct 12, 2023
6 checks passed
@cmp5987 cmp5987 deleted the cp/output-log branch October 12, 2023 03:40
hulto pushed a commit that referenced this pull request Oct 12, 2023
@cmp5987 @hulto
Cp/output log (#319)
a51e12a 
* feat(output-page): Add output page and filters

* fix(build): Build for production
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@cmp5987
217e0af 
 
Cp/output log (#319)

* feat(output-page): Add output page and filters

* fix(build): Build for production
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hulto hulto hulto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmp5987 @hulto