Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cp/sorting #316

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Cp/sorting #316

merged 3 commits into from
Oct 11, 2023

Conversation

cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Oct 11, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Adds sorting functionality to tables
  • Adds sorting instructions to QuestList and TaskList.
  • Adds custom sorting to task status and quest lastUpdated columns.
  • Fixes leftover test comments in output and console logs

@cmp5987 cmp5987 requested a review from hulto October 11, 2023 03:17
hulto
hulto approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but LGTM

tavern/internal/www/src/pages/quest-list/quest-table/QuestTable.tsx
},
// {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I had this for reference but we went the route of having output details in a drawer.

@hulto hulto merged commit 64ef4ba into main Oct 11, 2023
6 checks passed
@hulto hulto deleted the cp/sorting branch October 11, 2023 03:35
@hulto hulto mentioned this pull request Oct 11, 2023
Closed
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@cmp5987
cfbe58f 
 
Cp/sorting (#316)

* feat(sorting): Add sorting to tables

* fix(build): Build code for production

* fix(log): Remove console logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hulto hulto hulto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmp5987 @hulto