Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cp/small fixes #310

Merged
merged 3 commits into from
Oct 8, 2023
Merged

Cp/small fixes #310

merged 3 commits into from
Oct 8, 2023

Conversation

cmp5987
Copy link
Collaborator

@cmp5987 cmp5987 commented Oct 8, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • We add graphql endpoint handling for production and development enviroments
  • We change the content of the on finished output column to show current fished / total tasks.
  • We changed the styling of finished output to have green background if all tasks are marked finished
  • We added a react-code-block library four our quest task output
  • We are using specifically 0.0.8 of react-code-block because newer versions break when using typescript

@cmp5987 cmp5987 requested a review from hulto October 8, 2023 19:36
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 200 dead files makes me sad but okay 😢
Makes sense that the library we're using doesn't expose anyway to utilize the light build.
Not maintaining a fork of the library just to support light builds makes sense especially since it's an actively maintained project.
I agree adding a larger more complicated library to solve this doesn't make sense. - Hopefully we can open an issue with the library and merge the fix in an upstream version.

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #310 (c60b3c9) into main (0b820de) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #310   +/-   ##
=======================================
  Coverage   74.85%   74.85%           
=======================================
  Files          94       94           
  Lines        6120     6120           
=======================================
  Hits         4581     4581           
  Misses       1452     1452           
  Partials       87       87           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmp5987 cmp5987 merged commit d55a84d into main Oct 8, 2023
8 checks passed
@cmp5987 cmp5987 deleted the cp/small-fixes branch October 8, 2023 20:14
hulto pushed a commit that referenced this pull request Oct 8, 2023
* fix(env): Add envs for local running

* fix(codeblock): Change output to a codeblock

* fix(test): Testing lots of files getting created by react-syntax
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Cp/small fixes (#310)

* fix(env): Add envs for local running

* fix(codeblock): Change output to a codeblock

* fix(test): Testing lots of files getting created by react-syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants