Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase quest output drawer size #306

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Oct 5, 2023

What type of PR is this?

What this PR does / why we need it:

This PR:

  • Increases the drawer size to 80 characters to better display standard command output.
  • Adds whitespace-pre-wrap to the tome output to respect whitespace.

Which issue(s) this PR fixes:

@hulto hulto added the Frontend label Oct 5, 2023
@hulto hulto requested a review from cmp5987 October 5, 2023 00:53
Copy link
Collaborator

@cmp5987 cmp5987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm looks suspiciously familiar

@hulto hulto merged commit c70933e into main Oct 5, 2023
6 checks passed
@hulto hulto deleted the increase-quest-output-drawer-size branch October 5, 2023 15:07
KCarretto pushed a commit that referenced this pull request Oct 5, 2023
* Set paramdefs on parse.

* Removes debug statements.

* Should fix tests

* Missed this one

* Updated UI.

* Yay this works.

* Remove debug statements.

* Remove debug.

* Rebuild UI.

* auto reformat paramdefs to a JSON string.

* Increase param def string size.

* Updated UI

* Add a non param example.

* Add default value to params

* Remove test.

* Rebuild ui.

* Remove test tome.

* Add test 3

* Remove example 3

* Try updating parameters too.

* Manually generated

* Switch back to entry name metadata name is complex

* Increase quest output drawer size (#306)

* Set paramdefs on parse.

* Removes debug statements.

* Should fix tests

* Missed this one

* Updated UI.

* Yay this works.

* Remove debug statements.

* Remove debug.

* Rebuild UI.

* auto reformat paramdefs to a JSON string.

* Increase param def string size.

* Updated UI

* Add a non param example.

* Add default value to params

* Remove test.

* Rebuild ui.

* Remove test tome.

* Add test 3

* Remove example 3

* Try updating parameters too.

* Manually generated

* Switch back to entry name metadata name is complex

* Update UI.
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Increase quest output drawer size (#306)
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Parse tome paramdefs on startup (#298)

* Set paramdefs on parse.

* Removes debug statements.

* Should fix tests

* Missed this one

* Updated UI.

* Yay this works.

* Remove debug statements.

* Remove debug.

* Rebuild UI.

* auto reformat paramdefs to a JSON string.

* Increase param def string size.

* Updated UI

* Add a non param example.

* Add default value to params

* Remove test.

* Rebuild ui.

* Remove test tome.

* Add test 3

* Remove example 3

* Try updating parameters too.

* Manually generated

* Switch back to entry name metadata name is complex

* Increase quest output drawer size (#306)

* Set paramdefs on parse.

* Removes debug statements.

* Should fix tests

* Missed this one

* Updated UI.

* Yay this works.

* Remove debug statements.

* Remove debug.

* Rebuild UI.

* auto reformat paramdefs to a JSON string.

* Increase param def string size.

* Updated UI

* Add a non param example.

* Add default value to params

* Remove test.

* Rebuild ui.

* Remove test tome.

* Add test 3

* Remove example 3

* Try updating parameters too.

* Manually generated

* Switch back to entry name metadata name is complex

* Update UI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants