Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys.get_env() #274

Merged
merged 3 commits into from
Aug 16, 2023
Merged

sys.get_env() #274

merged 3 commits into from
Aug 16, 2023

Conversation

jabbate19
Copy link
Collaborator

What type of PR is this?

/kind feature
/kind eldritch-function

What this PR does / why we need it:

Adds sys.get_env() that returns a Dict of all environment variables for the current process.

Which issue(s) this PR fixes:

Fixes #259

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #274 (f278420) into main (4cc8bf2) will increase coverage by 2.14%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
+ Coverage   72.18%   74.33%   +2.14%     
==========================================
  Files          89       90       +1     
  Lines        5702     5844     +142     
==========================================
+ Hits         4116     4344     +228     
+ Misses       1500     1414      -86     
  Partials       86       86              
Files Changed Coverage Δ
implants/lib/eldritch/src/sys.rs 48.64% <50.00%> (+0.07%) ⬆️
implants/lib/eldritch/src/sys/get_env_impl.rs 95.45% <95.45%> (ø)
implants/lib/eldritch/src/lib.rs 92.82% <100.00%> (ø)

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@jabbate19 jabbate19 merged commit c682ff9 into main Aug 16, 2023
8 checks passed
@jabbate19 jabbate19 deleted the sys_get_env branch August 16, 2023 03:45
hulto pushed a commit that referenced this pull request Sep 30, 2023
* Add sys.get_env()

* I can't do alphabetical order
hulto pushed a commit that referenced this pull request Sep 30, 2023
* Add sys.get_env()

* I can't do alphabetical order
hulto pushed a commit that referenced this pull request Oct 5, 2023
* Add sys.get_env()

* I can't do alphabetical order
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
sys.get_env() (#274)

* Add sys.get_env()

* I can't do alphabetical order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Implement sys.getEnv() function to return local environment variables
2 participants