Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys.get_pid() #272

Merged
merged 4 commits into from
Aug 15, 2023
Merged

sys.get_pid() #272

merged 4 commits into from
Aug 15, 2023

Conversation

jabbate19
Copy link
Collaborator

What type of PR is this?

/kind documentation
/kind feature
/kind eldritch-function

What this PR does / why we need it:

Adds get_pid() to get current process PID

Which issue(s) this PR fixes:

Fixes #240

@jabbate19
Copy link
Collaborator Author

Dammit

@jabbate19 jabbate19 requested a review from hulto August 14, 2023 23:50
hulto
hulto approved these changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 nice!

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #272 (41ddd4b) into main (8c11caa) will increase coverage by 0.02%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
+ Coverage   74.14%   74.16%   +0.02%     
==========================================
  Files          88       89       +1     
  Lines        5782     5795      +13     
==========================================
+ Hits         4287     4298      +11     
- Misses       1409     1411       +2     
  Partials       86       86
Files Changed Coverage Δ
implants/lib/eldritch/src/sys.rs 48.57% <50.00%> (+0.08%) ⬆️
implants/lib/eldritch/src/lib.rs 92.82% <100.00%> (ø)
implants/lib/eldritch/src/sys/get_pid_impl.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jabbate19 jabbate19 merged commit e604106 into main Aug 15, 2023
8 checks passed
@jabbate19 jabbate19 deleted the sys_get_pid branch August 15, 2023 02:16
hulto pushed a commit that referenced this pull request Sep 30, 2023
@jabbate19 @hulto
sys.get_pid() (#272)
8a24796 
* Implement get_pid

* Add newline

* Add Sys Entry
hulto pushed a commit that referenced this pull request Sep 30, 2023
@jabbate19 @hulto
sys.get_pid() (#272)
8bcca85 
* Implement get_pid

* Add newline

* Add Sys Entry
hulto pushed a commit that referenced this pull request Oct 5, 2023
@jabbate19 @hulto
sys.get_pid() (#272)
e8dec38 
* Implement get_pid

* Add newline

* Add Sys Entry
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@jabbate19
5ff1b55 
 
sys.get_pid() (#272)

* Implement get_pid

* Add newline

* Add Sys Entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hulto hulto hulto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement sys.get_pid function
2 participants
@jabbate19 @hulto