Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys.get_user() #257

Merged
merged 5 commits into from
Aug 14, 2023
Merged

sys.get_user() #257

merged 5 commits into from
Aug 14, 2023

Conversation

jabbate19
Copy link
Collaborator

@jabbate19 jabbate19 commented Jul 29, 2023

What type of PR is this?

/kind documentation
/kind feature
/kind eldritch-function

What this PR does / why we need it:

Adds sys.get_user() to get current process user information

Test Function For

  • Linux
  • BSD
  • Mac
  • Windows

Other tasks

  • Write Tests

Which issue(s) this PR fixes:

Fixes #241

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Merging #257 (97a6a14) into main (268b091) will increase coverage by 0.48%.
The diff coverage is 90.69%.

@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
+ Coverage   74.80%   75.29%   +0.48%     
==========================================
  Files          87       88       +1     
  Lines        5394     5565     +171     
==========================================
+ Hits         4035     4190     +155     
- Misses       1273     1289      +16     
  Partials       86       86              
Files Changed Coverage Δ
implants/lib/eldritch/src/sys.rs 48.48% <22.22%> (-4.15%) ⬇️
implants/lib/eldritch/src/sys/get_user_impl.rs 94.44% <94.44%> (ø)
implants/lib/eldritch/src/lib.rs 92.82% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jabbate19
Copy link
Collaborator Author

Any recommended methods of writing tests for this?

@jabbate19 jabbate19 requested a review from hulto August 14, 2023 19:58
@jabbate19 jabbate19 marked this pull request as ready for review August 14, 2023 19:58
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@jabbate19 jabbate19 merged commit 9d2a792 into main Aug 14, 2023
8 checks passed
@jabbate19 jabbate19 deleted the sys_get_user branch August 14, 2023 22:02
hulto added a commit that referenced this pull request Sep 30, 2023
* Linux-Side Get User

* Fix Windows Implementation

* Add Test

* Fixup Windows Tests

---------

Co-authored-by: Hulto <[email protected]>
hulto added a commit that referenced this pull request Sep 30, 2023
* Linux-Side Get User

* Fix Windows Implementation

* Add Test

* Fixup Windows Tests

---------

Co-authored-by: Hulto <[email protected]>
hulto added a commit that referenced this pull request Oct 5, 2023
* Linux-Side Get User

* Fix Windows Implementation

* Add Test

* Fixup Windows Tests

---------

Co-authored-by: Hulto <[email protected]>
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
sys.get_user() (#257)

* Linux-Side Get User

* Fix Windows Implementation

* Add Test

* Fixup Windows Tests

---------

Co-authored-by: Hulto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement sys.get_user function
2 participants