Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

244 spicy up readmemd #245

Merged
merged 8 commits into from
Jul 23, 2023
Merged

244 spicy up readmemd #245

merged 8 commits into from
Jul 23, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Jul 21, 2023

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Expands the readme with images and a quick start guide.
Improves navigation and content of the docs.

Which issue(s) this PR fixes:

Fixes #244

@hulto hulto added documentation Improvements or additions to documentation cleanup Code cleanup and tech debt removal labels Jul 21, 2023
@hulto hulto linked an issue Jul 21, 2023 that may be closed by this pull request
@hulto hulto closed this Jul 21, 2023
@hulto hulto reopened this Jul 21, 2023
@hulto
Copy link
Collaborator Author

hulto commented Jul 21, 2023

Not ready for review blocking on other PRs.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #245 (250cbd2) into main (c0d7c5f) will increase coverage by 1.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
+ Coverage   72.83%   74.69%   +1.85%     
==========================================
  Files          87       87              
  Lines        5176     5236      +60     
==========================================
+ Hits         3770     3911     +141     
+ Misses       1320     1239      -81     
  Partials       86       86              

see 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌶️🌶️🌶️

@Cictrone
Copy link
Collaborator

u get review anyways

@hulto hulto merged commit 2700594 into main Jul 23, 2023
@hulto hulto deleted the 244-spicy-up-readmemd branch July 23, 2023 00:22
hulto added a commit that referenced this pull request Sep 30, 2023
* Spice up readme.

* Added example queries.

* Added golem examples.

* Read me assets.

* Update getting started doc.

* Revamping docs.
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
244 spicy up readmemd (#245)

* Spice up readme.

* Added example queries.

* Added golem examples.

* Read me assets.

* Update getting started doc.

* Revamping docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup and tech debt removal documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spicy up readme.md
2 participants