Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

242 implement pivotssh exec function #243

Merged
merged 6 commits into from
Jul 22, 2023
Merged

242 implement pivotssh exec function #243

merged 6 commits into from
Jul 22, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Jul 20, 2023

What type of PR is this?

What this PR does / why we need it:

This PR implements an SSH exec function allowing eldritch to run commands on a remote host over ssh.

Which issue(s) this PR fixes:

Fixes #242

@hulto hulto added feature New feature or request eldritch Related to the Eldritch language labels Jul 20, 2023
@hulto hulto linked an issue Jul 20, 2023 that may be closed by this pull request
Implement pivot.ssh_exec function #242
Closed
@codecov
Copy link

codecov bot commented Jul 20, 2023 •
edited
Loading

Codecov Report

Merging #243 (51953b0) into main (24a7a08) will decrease coverage by 0.16%.
The diff coverage is 70.04%.

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
- Coverage   74.85%   74.69%   -0.16%     
==========================================
  Files          87       87              
  Lines        5034     5236     +202     
==========================================
+ Hits         3768     3911     +143     
- Misses       1180     1239      +59     
  Partials       86       86
Impacted Files Coverage Δ
implants/lib/eldritch/src/pivot/ssh_exec_impl.rs 69.56% <69.56%> (+69.56%) ⬆️
implants/lib/eldritch/src/pivot.rs 60.16% <71.01%> (+12.79%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Cictrone
Cictrone approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, just alot of questions and sus.

implants/lib/eldritch/src/pivot.rs Show resolved Hide resolved
implants/lib/eldritch/src/pivot/ssh_exec_impl.rs Show resolved Hide resolved
implants/lib/eldritch/src/pivot/ssh_exec_impl.rs Show resolved Hide resolved
implants/lib/eldritch/src/pivot/ssh_exec_impl.rs Show resolved Hide resolved
implants/lib/eldritch/src/pivot/ssh_exec_impl.rs Show resolved Hide resolved
implants/lib/eldritch/src/pivot/ssh_exec_impl.rs Show resolved Hide resolved
@hulto hulto merged commit c0d7c5f into main Jul 22, 2023
@hulto hulto deleted the 242-implement-pivotssh_exec-function branch July 22, 2023 23:01
hulto added a commit that referenced this pull request Sep 30, 2023
@hulto
242 implement pivotssh exec function (#243)
2a41072 
* Added russh dep.

* Add ssh client support.

* Implement ssh exec and test.

* Improved docs and errors.
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@hulto
4c7d9cf 
 
242 implement pivotssh exec function (#243)

* Added russh dep.

* Add ssh client support.

* Implement ssh exec and test.

* Improved docs and errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cictrone Cictrone Cictrone approved these changes

Assignees
No one assigned
Labels
eldritch Related to the Eldritch language feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement pivot.ssh_exec function
2 participants
@hulto @Cictrone