-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cp/initial job form #230
Merged
Merged
Cp/initial job form #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #230 +/- ##
=======================================
Coverage 72.29% 72.29%
=======================================
Files 82 82
Lines 4675 4675
=======================================
Hits 3380 3380
Misses 1210 1210
Partials 85 85 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hulto
reviewed
Jul 13, 2023
hulto
reviewed
Jul 13, 2023
hulto
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥳
hulto
pushed a commit
that referenced
this pull request
Sep 30, 2023
* feat(job-form): Create initial form for job creation * fix(job-form): Add filter handling to target selection * fix(create-job): Add deletion and formik handling * fix(apollo): Basic apollo install * feat(create-job): Add tailwind, modify components * fix(create-job): Continue to build out steps and add icon * fix(select-session): Work on setting up session step * fix(select-sessions): Add virtualize and memo for checkboxes * fix(selected-only): Add selected only filter * fix(context): Group query and move it to context * fix(createJob): Add create job mutation * fix(submit-job): Add submit job * fix(package-lock): Remove package-lock.json
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
Cp/initial job form (#230) * feat(job-form): Create initial form for job creation * fix(job-form): Add filter handling to target selection * fix(create-job): Add deletion and formik handling * fix(apollo): Basic apollo install * feat(create-job): Add tailwind, modify components * fix(create-job): Continue to build out steps and add icon * fix(select-session): Work on setting up session step * fix(select-sessions): Add virtualize and memo for checkboxes * fix(selected-only): Add selected only filter * fix(context): Group query and move it to context * fix(createJob): Add create job mutation * fix(submit-job): Add submit job * fix(package-lock): Remove package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
UI is pretty important.
Improvements needed
Relevant Screenshots
Which issue(s) this PR fixes:
No UI :(