Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests.yml #207

Merged
merged 3 commits into from
Jun 14, 2023
Merged

Update tests.yml #207

merged 3 commits into from
Jun 14, 2023

Conversation

Cictrone
Copy link
Collaborator

needed

@Cictrone
Copy link
Collaborator Author

@KCarretto pls force merge this

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #207 (d846990) into main (4790540) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
- Coverage   72.19%   72.16%   -0.03%     
==========================================
  Files          83       83              
  Lines        4646     4646              
==========================================
- Hits         3354     3353       -1     
- Misses       1207     1208       +1     
  Partials       85       85              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ugg windows
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM fix those failing test tho ;)

@Cictrone
Copy link
Collaborator Author

TODO @KCarretto

@hulto
Copy link
Collaborator

hulto commented Jun 13, 2023

Also Kyle you'll have to change the required workflows / stages in the GitHub actions UI.
Currently imix and eldritch exist their but not in code so things are hanging.

@KCarretto KCarretto merged commit c945c0a into main Jun 14, 2023
@KCarretto KCarretto deleted the Cictrone-patch-1 branch June 14, 2023 22:26
hulto pushed a commit that referenced this pull request Jun 16, 2023
* Update tests.yml

needed

* Update tests.yml

ugg windows

* Update tests.yml

fml
Cictrone added a commit that referenced this pull request Jun 16, 2023
* sysshell now return dict with stdout stderr status

* Expanded sys exec output.

* Update tests.yml (#207)

* Update tests.yml

needed

* Update tests.yml

ugg windows

* Update tests.yml

fml

* 182 eldritch sleep blocks imix agent (#208)

* Couple tests.

* Resolve async errors.

* 193 resolve docs issues (#195)

* Updated docs.

* Added golem to toc.

* Fix typo start to sort by name.

* Add assets docs.

* Unified wording.

* Clean up spelling.

* Update tests.

* Removed double defined test.

---------

Co-authored-by: Nicholas O'Brien <[email protected]>
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Update tests.yml (#207)

* Update tests.yml

needed

* Update tests.yml

ugg windows

* Update tests.yml

fml
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
194 expand shell command to return exit code and stderr (#209)

* sysshell now return dict with stdout stderr status

* Expanded sys exec output.

* Update tests.yml (#207)

* Update tests.yml

needed

* Update tests.yml

ugg windows

* Update tests.yml

fml

* 182 eldritch sleep blocks imix agent (#208)

* Couple tests.

* Resolve async errors.

* 193 resolve docs issues (#195)

* Updated docs.

* Added golem to toc.

* Fix typo start to sort by name.

* Add assets docs.

* Unified wording.

* Clean up spelling.

* Update tests.

* Removed double defined test.

---------

Co-authored-by: Nicholas O'Brien <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants