193 resolve docs issues #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## main #195 +/- ##
==========================================
- Coverage 72.75% 70.03% -2.73%
==========================================
Files 83 83
Lines 4695 4655 -40
==========================================
- Hits 3416 3260 -156
- Misses 1194 1310 +116
Partials 85 85
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Milkshak3s
requested changes
May 18, 2023
docs/_docs/user-guide/eldritch.md
Outdated
| @@ -223,10 +228,12 @@ The <b>pivot.arp_scan</b> method is being proposed to allow users to enumerate h | |||
| The <b>pivot.port_forward</b> method is being proposed to providde socat like functionality by forwarding traffic from a port on a local machine to a port on a different machine allowing traffic to be relayed. | |||
|
|
|||
| ### pivot.ncat | |||
| `pivot.ncat(address: str, port: int, data: str, str: portocol ) -> str` | |||
| `pivot.ncat(address: str, port: int, data: str, portocol: str ) -> str` | |||
There was a problem hiding this comment.
portocol, or protocol?
There was a problem hiding this comment.
Or is this intentional :)
There was a problem hiding this comment.
😅 just wish I knew how to spell.
Milkshak3s
approved these changes
May 23, 2023
|
Yep haven't implemented those changes yet. |
hulto
added a commit
that referenced
this pull request
Jun 16, 2023
* Updated docs. * Added golem to toc. * Fix typo start to sort by name. * Add assets docs. * Unified wording. * Clean up spelling.
Cictrone
added a commit
that referenced
this pull request
Jun 16, 2023
* sysshell now return dict with stdout stderr status * Expanded sys exec output. * Update tests.yml (#207) * Update tests.yml needed * Update tests.yml ugg windows * Update tests.yml fml * 182 eldritch sleep blocks imix agent (#208) * Couple tests. * Resolve async errors. * 193 resolve docs issues (#195) * Updated docs. * Added golem to toc. * Fix typo start to sort by name. * Add assets docs. * Unified wording. * Clean up spelling. * Update tests. * Removed double defined test. --------- Co-authored-by: Nicholas O'Brien <[email protected]>
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
194 expand shell command to return exit code and stderr (#209) * sysshell now return dict with stdout stderr status * Expanded sys exec output. * Update tests.yml (#207) * Update tests.yml needed * Update tests.yml ugg windows * Update tests.yml fml * 182 eldritch sleep blocks imix agent (#208) * Couple tests. * Resolve async errors. * 193 resolve docs issues (#195) * Updated docs. * Added golem to toc. * Fix typo start to sort by name. * Add assets docs. * Unified wording. * Clean up spelling. * Update tests. * Removed double defined test. --------- Co-authored-by: Nicholas O'Brien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds golem to toc and fixes doc typos.