Add dict return type and updated test. #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulto
added
cleanup
Codecov Report
@@ Coverage Diff @@
## main #184 +/- ##
==========================================
- Coverage 73.11% 73.01% -0.10%
==========================================
Files 78 78
Lines 4247 4243 -4
==========================================
- Hits 3105 3098 -7
- Misses 1057 1060 +3
Partials 85 85
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…or-of-dicts-similar-to-port-scan
…or-of-dicts-similar-to-port-scan
…-similar-to-port-scan' of https://github.com/KCarretto/realm into 181-implement-process-list-results-as-a-vector-of-dicts-similar-to-port-scan
…or-of-dicts-similar-to-port-scan
hulto
deleted the
181-implement-process-list-results-as-a-vector-of-dicts-similar-to-port-scan
branch
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind eldritch-function
What this PR does / why we need it:
This PR allows users to more easily interact with the output from process.list() Eg:
#### Which issue(s) this PR fixes: Fixes #181