Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

150 feature imix platform information #160

Merged
merged 6 commits into from
Mar 23, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Mar 17, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds OS pretty name to imix to support the new graphql API.

Which issue(s) this PR fixes:

Fixes #150

@hulto hulto linked an issue Mar 17, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #160 (a7ef7e4) into main (9c63e50) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #160   +/-   ##
=======================================
  Coverage   56.17%   56.17%           
=======================================
  Files          28       28           
  Lines        1376     1376           
=======================================
  Hits          773      773           
  Misses        522      522           
  Partials       81       81           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@KCarretto KCarretto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D

@hulto hulto merged commit 292de05 into main Mar 23, 2023
@hulto hulto deleted the 150-feature-imix-platform-information branch March 23, 2023 01:55
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
150 feature imix platform information (#160)

* Implement os_pretty_name.

* Cleanup compiler warn.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report Platform Information
2 participants