[Tavern][bugfix] Fixed issue with transactional client #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bugfix
What this PR does / why we need it:
Updates two of our mutations (
claimTasks
andcreateJob
) to reload ents that were created/updated with the transactional client before returning them. This is because when the transactional client is used to commit the transaction, it can no longer be used to load ents. For regular usage this was fine, but the bug was encountered when attempting to traverse edges on the result (see the example mutation below). This is because the returned ent(s) would have embedded the transactional*ent.Client
, because that's the client they were loaded with. Further queries using that client would error, meaning additional graph traversals would fail like the example below:This produces a GraphQL error "sql: transaction has already been committed or rolled back".
Our test cases were updated to reflect the more complex queries that real world users may have to prevent regression.