Unable to get empty value from nullable instance like TextPrompt<Uri?>

[danielklecha]

I want to get AbsoluteUri or null but it's not supported by TextPrompt even with AllowEmpty=true.

var uri = await new TextPrompt<Uri?>( $"abc" )
    .AllowEmpty()
    .Validate( value =>
    {
        if ( !( value?.IsAbsoluteUri ?? true ) )
            return ValidationResult.Error( "[red]It must be absolute url[/]" );
        return ValidationResult.Success();
    } )
    .ShowAsync( AnsiConsole.Console, CancellationToken.None );

If I press enter then I get "Invalid input".

I suppose that input is string.Empty when we call TryConvertFromString.
UriConverter allow to convert from string.Empty and return null.
In that case condition in line 146 in TextPrompt should be modified and allow result to be null if conversion was successfull.

else if (!TypeConverterHelper.TryConvertFromString<T>(input, out result) || result == null && Nullable.GetUnderlyingType(typeof(T)) == null)
//or maybe
else if (!TypeConverterHelper.TryConvertFromString<T>(input, out result))

This issue could happen for other types if allow to convert from string.Empty and return null.
What do you think?

---

Please upvote 👍 this issue if you are interested in it.

[patriksvensson]

@danielklecha Could you create a minimal reproducable example for this?

[danielklecha]

@patriksvensson Sure 😄
I created console app in .net 6.
You must run it and press enter. Then you will see "Invalid input" message.
https://github.com/danielklecha/SpectreConsoleIssue

[nils-a]

The "problem" is the || result == null in

spectre.console/src/Spectre.Console/Widgets/Prompt/TextPrompt.cs

Line 147 in 0bbf9b8

else if (!TypeConverterHelper.TryConvertFromString<T>(input, out result) || result == null)

This makes TypeConverters that return null values (like the UriTypeConverter) yield "invalid" results.

I feel this is a bug. E.g. given the following really far-fetched example:

using System.ComponentModel;
using System.Globalization;
using Spectre.Console;

var thing = await new TextPrompt<Thing>("thing")
    .AllowEmpty()
    .ShowAsync(AnsiConsole.Console, CancellationToken.None);
if (thing == null)
    AnsiConsole.WriteLine("You selected a null value");
else
    AnsiConsole.WriteLine($"You selected {thing.Content}");


[TypeConverter(typeof(ThingConverter))]
public class Thing
{
    public Thing(string content)
    {
        Content = content;
    }

    public string Content { get; }
}


public class ThingConverter : TypeConverter
{
    public override bool CanConvertFrom(ITypeDescriptorContext? context, Type sourceType)
    {
        if (sourceType == typeof(string))
        {
            return true;
        }

        return base.CanConvertFrom(context, sourceType);
    }

    public override object? ConvertFrom(ITypeDescriptorContext? context, CultureInfo? culture, object value)
    {
        if (value is string strVal)
        {
            if (string.IsNullOrEmpty(strVal))
            {
                return null;
            }

            if (strVal.EndsWith("a"))
            {
                return null;
            }

            return new Thing(strVal);
        }

        return base.ConvertFrom(context, culture, value);
    }
}

The TypeConverter returns null for all strings ending in a. (As I said: Really far-fetched...)
So an (IMHO) valid input of "trallala" would result in an "invalid input" message.

[danielklecha]

Could someone modify TextPrompt and update one line? It generates issues with all nullable types.

else if (!TypeConverterHelper.TryConvertFromString<T>(input, out result))

[nils-a]

@danielklecha simply removing that || result == 0 will open a long bunch of nullable issues. So, I feel it's not as easy as that.
Also, that would be a breaking change, so we'd need to think about that.

We're certainly open to suggestions, though.

/cc @iraklikhitarishvili - this answers your question in #998, probably.