Replies: 1 comment 4 replies
-
|
Not a bug, moving this to discussions. |
Beta Was this translation helpful? Give feedback.
-
|
I have no idea. There is probably a reason, but maybe not. |
Beta Was this translation helpful? Give feedback.
-
|
Is benchmark really needed? It's kind of obvious. |
Beta Was this translation helpful? Give feedback.
-
|
@m5x, I think what Patrik is saying is that if this is a perf issue you are seeing, we are happy to take a PR, but with it not being anything we are encountering that PR would be nice to have tests and some benchmarks to go along with it. |
Beta Was this translation helpful? Give feedback.
-
|
No sweat. We evidently have different opinions about what is acceptable in good quality code. I would call such usage of List<> "programmer's faux pas" and fix it immediately while you don't even seem to see it. I guess that makes further discussion on this topic pointless. |
Beta Was this translation helpful? Give feedback.
-
Is there a reason for replacing items in List<> instances in method TableRowCollection.Update by removing old item and then inserting new one at the same index? This makes List<> do unnecessary copying which could be avoided by simply replacing the old item with new one (i.e. list[index] = newItem).
Beta Was this translation helpful? Give feedback.
All reactions