[DO NOT REVIEW] Fix the SubgraphFusion bug #1688
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratyai
force-pushed
the
subgraph-fusion-noop-cleanups
branch
from
c01f69f
to
bd0aab0
Compare
like: ```c++ cpp.reshape_strides(Range([(0, 4, 1), (0, 5, 1)]), None, None, [2, 3, 5]) ``` and crashes with an index error.
outside the loop. It seems to be a typo on `iedge`.
need to be tied to the class itself. Remove their unnecessary arguments.
+ Removing unnecessary imports.
pratyai
force-pushed
the
subgraph-fusion-noop-cleanups
branch
from
e2c009d
to
8ce7055
Compare
pratyai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1687. The problem was about using a memlet's
subsetfield wheredst_subsetwould be more appropriate.Only the last commit is the bug-fix: cab4d26
The rest of the changes are about:
fuse()function out to their own helper functions so that it is actually possible to follow its logic. [This part is not complete though, since I only took out the parts until I was able to fix the bug]