Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite tests to use pest instead of phpunit #179

Merged
merged 5 commits into from
Mar 15, 2022
Merged

Conversation

otsch
Copy link
Contributor

@otsch otsch commented Mar 7, 2022

Also fix a deprecation warning occuring when running PHP 8.1 in Graph.php, that automatic conversion of false to array is deprecated.

otsch added 3 commits March 7, 2022 21:10
Also fix a deprecation warning occuring when running PHP 8.1 in
Graph.php, that automatic conversion of false to array is deprecated.
@otsch
Copy link
Contributor Author

otsch commented Mar 9, 2022

OK, actions say that there's no code coverage driver...just tried this: 05760ab hope it helps.

otsch added 2 commits March 9, 2022 14:36
Tried with the exact same coverage options as it was previously with
phpunit, which seems to also work, so use that.
@Gummibeer Gummibeer requested a review from freekmurze March 15, 2022 12:42
@freekmurze freekmurze merged commit 165b39f into spatie:main Mar 15, 2022
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants