Schema v11 Update & release [1/3][🎃 hacktober] #169
Conversation
the previous keys no longer are used. the "schema:" prefix is used now instead (cherry picked from commit 19d1515)
Rather than updating all of our logic to parse things differently - this simply corrects all the prefixed data to expanded form. From there, the logic that pulls things together works fine again. This enables the generator to be updated sooner than later. Given that the generator is run rarely a more efficient strategy could be created via building a new generator logic at any time without affecting end-user versions. (cherry picked from commit ef09856)
* docs-schema-v10: Add helpful table... update changelog for accepted PRs in schema V10 based release
...no sense in releasing with the unpatched v11 that had errors.
mallardduck
changed the title
Fix merge conflicts and update changelog
rather than fixing it lets remove it to match the rest of teh generator code
mallardduck
changed the title
|
Updated to remove the table from readme file and got changelog to match previous PR/release. |
|
Using the awesome php-semver-checker tool I am more easily able to compare the changes than on GitHub's diff page. This way I can point the tool to only analyze the src folder too. While it does suggest this be a "MAJOR" release, this due to all sorts of new added methods. Which it considers as major changes by default rather than a "MINOR" change. That said, it no longer includes any removals! So the subsequent PRs will need to be tweaked...but I figure I'll adjust those once this one is merged in and those are synced with master branch. |
|
Awesome! 🎉 One of the most productive and serious PR series for https://hacktoberfest.digitalocean.com/ I've ever seen! 🤯 |
This is the second schema upgrade and next release PR.
With this set of PRs I'm going to be making sure to get the docs along the way too.
That way #168 will be the only errant one with only docs fixes to account for tagging a release.