Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make work with no header... #5

Closed
leeovery opened this issue Jun 19, 2019 · 1 comment
Closed

Make work with no header... #5

leeovery opened this issue Jun 19, 2019 · 1 comment

Comments

@leeovery
Copy link

Hey,

Im happy to do a PR but thought Id check first...

I have a need to setup webhooks from a third part app. But as its a third party sending the data I cant control how and if they send headers.

I tried setting up a SignatureValidator which just returns true, but the package rejects empty headers early.

How do you feel about integrating the signature check into the validator? That way a custom validator would have full control over that process, and would enable people to avoid headers altogether if desired.

Thanks for another amazing package!!! Ill be sending postcards very soon when I launch :)

Lee

@freekmurze
Copy link
Member

I'd accept a fully tested, non-breaking PR for this. Thank you for the kind words. Looking forward to the postcards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants