Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling could be more precise #46

Closed
Leamsi9 opened this issue Feb 26, 2020 · 1 comment
Closed

Error handling could be more precise #46

Leamsi9 opened this issue Feb 26, 2020 · 1 comment

Comments

@Leamsi9
Copy link

Leamsi9 commented Feb 26, 2020

Thanks for a package I'm enjoying sinking my teeth into.

I forgot to rerun my migrations so the web calls database was AWOL. What I got was an "Invalid Signature" error, so I naturally spent a while debugging the signature config and secret. It was not until I commented out the throw WebhookFailed::invalidSignature(); in WebhookProcessor.php that I got a missing table error, which obviously had nothing to do with the signature being invalid. Once I ran my migrations my signature was fine and all worked as intended.

Might be worth differentiating signature errors from other errors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants