Set response on webhook request error?

[dmason30]

I am willing to PR this if needed but I would like to have access to the response even when the webhook call has failed. Guzzle RequestException exceptions have a getResponse method which allows you to get this.

Current code CallWebhookJob

try {
    $this->response = $client->request(...);

   ...
} catch (Exception $exception) {
    /** @var \Spatie\WebhookServer\BackoffStrategy\BackoffStrategy $backoffStrategy */
    $backoffStrategy = app($this->backoffStrategyClass);

    $waitInSeconds = $backoffStrategy->waitInSecondsAfterAttempt($this->attempts());

    $this->dispatchEvent(WebhookCallFailedEvent::class);

    $this->release($waitInSeconds);
}

Proposed change to CallWebhookJob?
Detect if exception is a RequestException and set the response.

try {
    $this->response = $client->request(...);

   ...
} catch (Exception $exception) {
    
    if ($exception instanceof GuzzleHttp\Exception\RequestException) {
        $this->response = $exception->getResponse();
    }

  ...
}

[freekmurze]

Thanks for the suggestion. Submit a PR with tests for this. 👍