Skip to content

Commit 8cf08be

Browse files
authored
Use default webhook response as fallback (#60)
* Use default webhook response as fallback * Fix StyleCI issue Co-authored-by: GuntherDebrauwer <[email protected]>
1 parent d21404f commit 8cf08be

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

src/WebhookConfig.php

+3-2
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
use Spatie\WebhookClient\Exceptions\InvalidConfig;
66
use Spatie\WebhookClient\SignatureValidator\SignatureValidator;
77
use Spatie\WebhookClient\WebhookProfile\WebhookProfile;
8+
use Spatie\WebhookClient\WebhookResponse\DefaultRespondsTo;
89
use Spatie\WebhookClient\WebhookResponse\RespondsToWebhook;
910

1011
class WebhookConfig
@@ -43,11 +44,11 @@ public function __construct(array $properties)
4344
}
4445
$this->webhookProfile = app($properties['webhook_profile']);
4546

46-
$webhookResponseClass = $properties['webhook_response'] ?? RespondsToWebhook::class;
47+
$webhookResponseClass = $properties['webhook_response'] ?? DefaultRespondsTo::class;
4748
if (! is_subclass_of($webhookResponseClass, RespondsToWebhook::class)) {
4849
throw InvalidConfig::invalidWebhookResponse($webhookResponseClass);
4950
}
50-
$this->webhookResponse = app($properties['webhook_response']);
51+
$this->webhookResponse = app($webhookResponseClass);
5152

5253
$this->webhookModel = $properties['webhook_model'];
5354

tests/WebhookConfigTest.php

+9
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,15 @@ public function it_validates_the_webhook_response()
6161
new WebhookConfig($config);
6262
}
6363

64+
/** @test */
65+
public function it_uses_the_default_webhook_response_if_none_provided()
66+
{
67+
$config = $this->getValidConfig();
68+
$config['webhook_response'] = null;
69+
70+
$this->assertInstanceOf(DefaultRespondsTo::class, (new WebhookConfig($config))->webhookResponse);
71+
}
72+
6473
/** @test */
6574
public function it_validates_the_process_webhook_job()
6675
{

0 commit comments

Comments
 (0)