Install Laravel Pint #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imdhemy
commented
Dec 23, 2022
| @@ -164,10 +164,10 @@ protected function validate(string $attribute, string $item): array | |||
|
|
|||
There was a problem hiding this comment.
No changes, only fixing style using Pint.
imdhemy
commented
Dec 23, 2022
| @@ -16,12 +16,10 @@ public function setUp(): void | |||
|
|
|||
There was a problem hiding this comment.
No changes, only fixing style using Pint.
|
Thanks! Dropping a PHP version is not a breaking change as composer will not pull in the updated package if you don't have the required PHP version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR installs Laravel Pint.
Laravel Pint requires
PHP 8.0or higher, so I've also dropped support forPHP 7.4. This requires a major version bump.I also used the default coding style from Pint as it's already opinionated and I wasn't sure what to use. So, feel free to suggest changes.
I've also added a GitHub action to run Pint inspections on PRs and pushes.