Ignore the phpunit.xml file by default
#362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the phpunit.xml.dist so we can overwrite phpunit configuration locally. But the file is not ignored by git. This makes it possible to accidentally push your local version of the configuration file to the repository. Ignoring this file will prevent that from happening.
|
Dear contributor, because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it. |
|
Well, I was still waiting on a reaction from Spatie :') |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the phpunit.xml.dist so we can overwrite phpunit configuration
locally. But the file is not ignored by git. This makes it possible to
accidentally push your local version of the configuration file to the
repository. Ignoring this file will prevent that from happening.
Just a small PR, but I like to split up my PR's instead of pushing a big change in one time.