Allow LDAP model lookup from Auth provider #2744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. It seems we're doing similar lookups in a couple of the |
|
I see.. I could split out the helper into a new function and use that in the guard, as well as the in the helper function I just modified?
By: Jason: Page
All Rights Reserved Without Prejudice
From: Chris Brown ***@***.***>
Sent: Wednesday, 23 October 2024 18:56
To: spatie/laravel-permission ***@***.***>
Cc: Jason Page ***@***.***>; Author ***@***.***>
Subject: Re: [spatie/laravel-permission] Update helpers.php (PR #2744)
Thanks.
It seems we're doing similar lookups in a couple of the Guard class methods as well.
I wonder if we should take this logic there, and simply have this function call it?
—
Reply to this email directly, view it on GitHub<#2744 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQHX4OXMLBS5ZZJURCIRISDZ47IL3AVCNFSM6AAAAABQO7BBTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZSHA2TINRTGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
|
I was thinking the other way around: Update the |
|
Yeah.. I saw that too after I started looking more into it..
Let me dig a little more 😊
By: Jason: Page
All Rights Reserved Without Prejudice
From: Chris Brown ***@***.***>
Sent: Wednesday, 23 October 2024 19:47
To: spatie/laravel-permission ***@***.***>
Cc: Jason Page ***@***.***>; Author ***@***.***>
Subject: Re: [spatie/laravel-permission] Allow LDAP model lookup from Auth provider (PR #2744)
I was thinking the other way around: Update the Guard class (can an existing method be used here?), and then the helper can call the method in the Guard class, kinda like a proxy/shorthand.
—
Reply to this email directly, view it on GitHub<#2744 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQHX4ORCZLJ56DV462NUB3LZ47OHZAVCNFSM6AAAAABQO7BBTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZSHE4TCMJVGY>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
|
better? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows for ldap authentication where the model differs from the database model - ldap still uses the App\Models\User, just indirectly.