Conditionally Show Routes #78
skylerkatz
started this conversation in
Ideas
Replies: 1 comment
-
|
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hello!
I was wondering if you would be interested in a PR that would only register the
_ignition
routes if the app was inAPP_DEBUG=true
, or even a dedicatedIGNITION_ROUTES_ENABLED
config value.I bring this up because we have been looking through our production logs and noticed many different visits to the routes that ignition registers. I know that you make a check for
ensureLocalEnvironment
in theExecuteSolutionController
but no such checks are made in the other controllers.If this is something you are interested in, I would be happy to submit a PR.
My current workaround is to just update the route prefix to something else, but I am still not sure we need the routes at all in production.
Thanks!
Beta Was this translation helpful? Give feedback.
All reactions