Dialog cuts buttons

[alexolog]

See http://tinypic.com/view.php?pic=2i9361e&s=8
Running FF30 with Classic Theme Restorer

[spasche]

I tried to reproduce on Windows 8.1 with Firefox 30 by installing Open in Browser, FlashGot and Classic Theme Restorer, but the dialog looks fine for me:

What's your operating system?

[alexolog]

On 2 different machines: WinXP/SP3 and Win7

Perhaps there's a conflict with OpenDownload2?
https://addons.mozilla.org/en-US/firefox/addon/opendownload-10902/

[dertuxmalwieder]

I - as the author of OpenDownload2 - actually doubt that my extension fails, the only cases where there were major layout issues were always related to Open In Browser. Does your extension maybe resize the dialog?

[spasche]

The extension doesn't resize the dialog. I couldn't reproduce on a Windows 7 vm, with a few extensions loaded. I can suggest that you try with a new clean profile, and add your extensions one by one until you see the problem happen. Then you can determine which extension is responsible.

[alexolog]

Try with an executable to actually trigger the [Run] button

[spasche]

Ok, I can reproduce if I only keep FlashGot and Open in Browser.

Apparently the dialog adapts to the content, but sometimes it is not tall enough. FlashGot doesn't seem to set the height explicitly. I don't know why the dialog isn't auto-sized properly, maybe that's because some elements are added dynamically after the dialog is rendered.

Who is responsible and what the fix should be? Not sure about that. If someone has a good idea and a patch or pull request that's welcome ;-).

[dertuxmalwieder]

Maybe check position/size of the "OK" button and compare them to the dimensions of the window?

[spasche]

Yeah, that could be an option. Care should be take to do the resizing after all other extensions have populated the dialog (using a timeout with some polling for instance).

Honestly I don't think I'll have time to implement this in the near future (and as I'm not using FlashGot that's not high on my todo list). If someone wants to tackle this, I'm happy to give directions.

[dertuxmalwieder]

I'm busy investigating about OD² 4.0's missing SeaMonkey compatibility, so I can't really help. :/

[spasche]

Sure, no problem. I wasn't implying that you should implement it ;-)

[alexolog]

Maybe talk to FlashGot's author?

[alexolog]

Is there some progress on this?

[dertuxmalwieder]

I haven't fiddled with it yet. Should I (have to)?

[alexolog]

Please do!

[dertuxmalwieder]

Damn :(

[alexolog]

Cookie?
http://www.chick-fil-a.com/Media/Img/catalog/Food/XLarge/Cookie.png

[dertuxmalwieder]

Appreciated!

[alexolog]

The cookie is getting stale...