-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] InvenTree 0.12.0 broke parameter handling #165
Comments
@T0jan Would inventree/InvenTree#5160 fix this problem? |
@eeintech probably, as it resulted from the discussion, have not tested yet. |
So after a bit of testing I can confirm it works. As they have put this fix behind a server setting now we should add a note to the README to make sure everyone who uses Ki-nTree knows he has to set this flag. Also they only added it to the 0.13.0 preview so 0.12.x versions of InvenTree will probably never work with Ki-nTree again. I also thought a bit if there is a way to automatically convert the non compliant units the suppliers use (e.g. "Ohms" instead of "ohm"), but the only usable idea I got would be look-up tables and I don't want to go down this road in this case here. |
Hello @T0jan Thanks for the feedback, do you know why this fix wasn't brought in into point releases of v12? |
@eeintech as far as I understand they don't really see it as bug/fix but more as a feature added to the new unit control they added with 0.12. |
inventree/InvenTree#5160 was merged in Inventree 0.12.6. I have tested Ki-nTree 0.5.3 and it works fine on my Inventree 0.12.6 with a sample DigiKey component (and parameters seem to be transferred fine). |
Hi @kongr45gpen Yes @T0jan also confirmed it works with the latest Ki-nTree version too. However for |
Small note here: InvenTree removed the enforced checks on parameters completely for now, so it is not needed to set the switch in the settings (the switch actually is not there anymore from at least 0.12.8 onward). |
@T0jan That's good news, less doc for us! |
@eeintech They reintroduced the switch for 0.13.0 so we have to document it... |
@T0jan Good point. I haven't had much time those last few weeks/months but I'm going to try to push a new release early next year. |
The recent changes to InvenTree parameter handling especially the now way harsher filtering of parameter values breaks the current approach of just taking the values from e.g. digikey and creating new part parameters with them. As of now no special characters are allowed for parameters with standard units and also empty parameter with
-
as placeholder are no longer possible. I opened a discussion on IvenTree for them to review the changes but maybe there also needs to be developed a workaround in the meantime.The text was updated successfully, but these errors were encountered: