Skip to content

Add delta update attributes for validating an app hasn't been stripped #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zorgiepoo opened this issue Aug 1, 2022 · 0 comments · Fixed by #2231
Closed

Add delta update attributes for validating an app hasn't been stripped #2219

zorgiepoo opened this issue Aug 1, 2022 · 0 comments · Fixed by #2231
Milestone

Comments

@zorgiepoo
Copy link
Member

zorgiepoo commented Aug 1, 2022

It is valid for users to strip localization files in an app bundle or strip mach-o architectures from binaries inside the app. Neither of these things if done properly invalidate an app bundle's code signature. However from a delta update's point of view, this will invalidate being able to apply a delta update, which will result in a full download after failing to apply a delta.

We could potentially do better by not even downloading delta updates (which we know will fail to apply) in this case. We could add attributes such as Sparkle's expected executable size and a partial sample handful of Sparkle's expected *.lproj locale directories. We can then validate the expected sizes or presence of these, and if they fail our expectation, then skip downloading the delta update.

For example: sparkle:deltaFromSparkleExecutableSize="1779328" sparkle:deltaFromSparkleLocales="en,ca,fr,hr,hu"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant