Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in writing register #4

Open
michaelcroquette opened this issue Jan 21, 2022 · 2 comments
Open

Errors in writing register #4

michaelcroquette opened this issue Jan 21, 2022 · 2 comments

Comments

@michaelcroquette
Copy link

Hi,

I bought the Sparkfun Clock 5P49V60 card a month ago and after playing with it for a month I found a couple of issues in the library :

-When writing the integer part of the divider's register there is an error, you're only shifting the most significant bits by 3 and not 4. This causes the divider number to not be 100 but 196 for most of your examples. It's actually a lucky mistake because the VCO doesn't work at 1600 MHz apparently (btw it would be nice to have the working frequency band of the VCO, I couldn't find it anywhere on the Sparkfun website)

-In a lot of function you are using a 8 bits integer to code a 12 bits integer.

-When setting the fractional part of the frequency output divider you forgot to shift the 6 least significant bits by two.

-In example 2, you're modifying two times clock one.

Best,
Michael

@michaelcroquette
Copy link
Author

#5

@edspark
Copy link
Collaborator

edspark commented Jan 24, 2022

Excellent, I'm peeling through your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants