-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: run tests on linux, macos and windows and release builds on ta… #370
Conversation
✅ Deploy Preview for robyn canceled.
|
@@ -1,6 +1,6 @@ | |||
requests==2.26.0 | |||
pytest==6.2.5 | |||
maturin | |||
uvloop | |||
uvloop; platform_system!="Windows" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
niceee.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know that was a thing until I worked on this PR 😄
@@ -2,7 +2,7 @@ pytest==6.2.5 | |||
maturin==0.12.11 | |||
watchdog | |||
requests==2.26.0 | |||
uvloop==0.17.0 | |||
uvloop==0.17.0; platform_system!="Windows" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nicee..
I might have a hunch why this is happening. The Just one question , how is the proposal different from our current way? Don't we still build a package on every PR and push to main? And release on tags? |
Ok thanks, that's a first step for investigating the comptibility with Windows. There is a difference, as with this PR there are a lot less jobs running on push and PRs (see the pipeline of this PR for reference). Also, previously we built a release package on every push and PRs, but didn't do anything with it. The only time when the builds were used was when a tag was released that would trigger the "Release" job for an upload to Pypi. In summary: Previous pipeline:
This pipeline:
I didn't test the tag creation pipeline, but kept the same jobs as before so it should work fine |
@AntoineRR , in this PR , are we depending on the tests to pass to build the packages? |
@sansyrox no, the test and release workflow are independant of each other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Now we have more information about windows builds!
* chore: run tests on linux, macos and windows and release builds on tag creation only (#370) * chore: address the suggestions
Description
This PR fixes #310
This is a proposal for a new CI/CD pipeline:
It seems like the tests do not pass on windows for now, adding this CI could be a good first step to fix them.