Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--fast flag inspired by sanic framework #636

Closed
tushar5526 opened this issue Oct 8, 2023 · 8 comments · Fixed by #931
Closed

--fast flag inspired by sanic framework #636

tushar5526 opened this issue Oct 8, 2023 · 8 comments · Fixed by #931
Labels
enhancement New feature or request

Comments

@tushar5526
Copy link
Contributor

Sanic has its own webserver along with support for external webservers. Servers like uvicorn, gunicorn leave it up to the users to tweak the value of processes, workers or threads to find the best combination which gives the best performance.

But Sanic's own webserver has a --fast flag which automatically optimises these values according to your server. Robyn should support something like it to tweak the values of processes and workers.

@tushar5526 tushar5526 added the enhancement New feature or request label Oct 8, 2023
@sansyrox
Copy link
Member

Hey @tushar5526 👋

That is a great idea. Thank you. I will have a look 😄

@mn3711698
Copy link

mn3711698 commented Nov 30, 2023

Currently encountering high concurrency issues, please as soon as possible @sansyrox thank you

@sansyrox
Copy link
Member

Hey @mn3711698 👋

Can you please explain a bit more ? What do you mean by this

Currently encountering high concurrency issues, please as soon as possible

How are you running Robyn?

@mn3711698
Copy link

mn3711698 commented Dec 4, 2023

@sansyrox

i know just lite english.
my website running Robyn.

[program:ro19]
environment =PYTHONPATH=/var/vcom/,LANG=zh_CN.UTF-8,LC_CTYPE=zh_CN.UTF-8,LC_ALL=zh_CN.UTF-8
directory = /var/vcom/
command = /usr/local/bin/python3 ./run_apiro19.py --workers 5
autostart = true
autorestart=true
user = root
redirect_stderr = true
stdout_logfile = /var/log/ro19.log

[program:ro20]
environment =PYTHONPATH=/var/vcom/,LANG=zh_CN.UTF-8,LC_CTYPE=zh_CN.UTF-8,LC_ALL=zh_CN.UTF-8
directory = /var/vcom/
command = /usr/local/bin/python3 ./run_apiro20.py --workers 5
autostart = true
autorestart=true
user = root
redirect_stderr = true
stdout_logfile = /var/log/ro20.log

[program:ro21]
environment =PYTHONPATH=/var/vcom/,LANG=zh_CN.UTF-8,LC_CTYPE=zh_CN.UTF-8,LC_ALL=zh_CN.UTF-8
directory = /var/vcom/
command = /usr/local/bin/python3 ./run_apiro21.py --workers 5
autostart = true
autorestart=true
user = root
redirect_stderr = true
stdout_logfile = /var/log/ro21.log

Robyn should support something like it to tweak the values of processes and workers ?

@sansyrox
Copy link
Member

sansyrox commented Dec 4, 2023

Hey @mn3711698 👋

It is super easy to do that in Robyn 😄

Just do python3 app.py --workers=N --processes=M

@sansyrox
Copy link
Member

sansyrox commented Dec 4, 2023

@sansyrox
Copy link
Member

sansyrox commented Dec 4, 2023

Also, @mn3711698 , I would love to see your website 😄 You can share it with me on Discord if that is more comfortable.

@sansyrox sansyrox pinned this issue Aug 18, 2024
@sansyrox
Copy link
Member

Hey @mn3711698 @tushar5526 This has been introduced in v0.60.2

@sansyrox sansyrox unpinned this issue Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants