Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Can't set keybinds to certain keys #7612

Open
S33R-OF-PYR3 opened this issue Jan 29, 2024 · 2 comments
Open

[Bug Report] Can't set keybinds to certain keys #7612

S33R-OF-PYR3 opened this issue Jan 29, 2024 · 2 comments

Comments

@S33R-OF-PYR3
Copy link

S33R-OF-PYR3 commented Jan 29, 2024

Description of Issue

Attempting to set any keybind to shift, control, or alt (mouse buttons are fine) does not register the input and doesn't allow the keybind to be set to those buttons. I've seen a handful of bugs pertaining to this issue for 1.18, and that they were solved, however the issue remains in 1.20.1.

Steps to Reproduce

  1. Launch Forge version 47.2.0 for Minecraft 1.20.1
  2. Install OptiFine_1.20.1_HD_U_I6 in the mods folder
  3. Open key bind menu
  4. Attempt to set any control to shift, control, or alt

OptiFine Version

OptiFine_1.20.1_HD_U_I6

Installation Method

Installed as a mod along side Forge

Fabric/Forge Version

47.2.0

@Jiingy Jiingy changed the title [Bug Report] Modifier Keybinds Broken for 1.20.1 [Bug Report] Can't set keybinds to certain keys Mar 5, 2024
@Jiingy
Copy link
Collaborator

Jiingy commented Mar 5, 2024

Can confirm this behavior is present. The keybind cannot be unselected once shift, alt, or ctrl is set.
I've updated the issue to only include relevant information.

@sp614x
Copy link
Owner

sp614x commented Mar 15, 2024

OptiFine_1.20.1_HD_U_I6 is compatible with Forge 47.2.18 and with it the keybinds work correctly.
It looks like Forge 47.2.10 has added some keybind changes which are not backwards compatible and this makes problems with the older 47.2.0:

 - 47.2.10 Rework KeyModifiers system to properly allow keybinds to be triggered when multiple modifiers are pressed.
           Fix setting keybinds whel using keyboard inputs to select the menu. Closes #9793
 - 47.2.9  Fix KeyModifiers not being properly taken into account. Closes #9806

Relevant:
MinecraftForge/MinecraftForge#9793
MinecraftForge/MinecraftForge#9806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants