Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not force set ntp servers #174

Open
directionless opened this issue Nov 13, 2017 · 2 comments
Open

Do not force set ntp servers #174

directionless opened this issue Nov 13, 2017 · 2 comments

Comments

@directionless
Copy link
Contributor

There are cases where one does not want any ntp servers. Perhaps a node is using pools, or perhaps it's only using peers.

However, #170 changed the behavior here. As
implemented in https://github.com/rhass/ntp/blob/master/recipes/default.rb#L61-L69

if node['ntp']['servers'].empty?
  node.default['ntp']['servers'] = [
    '0.pool.ntp.org',
    '1.pool.ntp.org',
    '2.pool.ntp.org',
    '3.pool.ntp.org',
  ]
  Chef::Log.debug 'No NTP servers specified, using default ntp.org server pools'
end

I'm not sure this was intentional or accidental.

@iennae
Copy link

iennae commented Nov 29, 2017

Thanks for reporting. It looks like an unintended side effect of fixing this on mac os.

@directionless
Copy link
Contributor Author

I might have misblamed #170, this may have always been true (which would represent a bug with my initial pools PR)

Regardless, I have fixed this in #178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants