Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/verify/solc-json schema incorrect #35

Closed
numtel opened this issue Feb 13, 2025 · 1 comment · Fixed by ethereum/sourcify#1927
Closed

/verify/solc-json schema incorrect #35

numtel opened this issue Feb 13, 2025 · 1 comment · Fixed by ethereum/sourcify#1927
Assignees

Comments

@numtel
Copy link

numtel commented Feb 13, 2025

There aren't so many levels in the files object.

This is what's shown on the docs now:

{
  "address": "0x07880D44b0f7b75464ad18fc2b980049c40A8bc3",
  "chain": "1",
  "files": {
    "value": {
      "SolcJsonInput.json": "{...}"
    }
  },
  "compilerVersion": "0.8.4+commit.c7e474f2",
  "contractName": "Storage",
  "creatorTxHash": "0xb7efb33c736b1e8ea97e356467f99d99221343f077ce31a3e3ac1d2e0636df1d"
}

But this gives me an error that files/value needs to be a string.

The docs should instead show this:

{
  "address": "0x07880D44b0f7b75464ad18fc2b980049c40A8bc3",
  "chain": "1",
  "files": {
    "value": "{...}"
  },
  "compilerVersion": "0.8.4+commit.c7e474f2",
  "contractName": "Storage",
  "creatorTxHash": "0xb7efb33c736b1e8ea97e356467f99d99221343f077ce31a3e3ac1d2e0636df1d"
}
@kuzdogan
Copy link
Member

kuzdogan commented Feb 13, 2025

Good catch, thanks!

Will be fixed by ethereum/sourcify#1927

Also keep in mind we will release a new verification API with APIv2 this quarter ethereum/sourcify#1367 https://sourcify.stoplight.io/docs/sourcify-apiv2/branches/main

@github-project-automation github-project-automation bot moved this from Sprint - In Progress to Sprint - Done in Sourcify Public Feb 13, 2025
@marcocastignoli marcocastignoli moved this from Sprint - Done to COMPLETED in Sourcify Public Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants