From bc93ca2a990dd2fea32f8eacdce234587dbb66d2 Mon Sep 17 00:00:00 2001 From: Ian Y Date: Wed, 16 Apr 2025 13:21:19 +0800 Subject: [PATCH] perf: leverage `try-with-resources` statement when handling input streams --- android/src/main/java/com/rnfs2/RNFSManager.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/android/src/main/java/com/rnfs2/RNFSManager.java b/android/src/main/java/com/rnfs2/RNFSManager.java index 4f79049e..494f4830 100755 --- a/android/src/main/java/com/rnfs2/RNFSManager.java +++ b/android/src/main/java/com/rnfs2/RNFSManager.java @@ -215,8 +215,7 @@ public void exists(String filepath, Promise promise) { @ReactMethod public void readFile(String filepath, Promise promise) { - try { - InputStream inputStream = getInputStream(filepath); + try (InputStream inputStream = getInputStream(filepath)) { byte[] inputData = getInputStreamBytes(inputStream); String base64Content = Base64.encodeToString(inputData, Base64.NO_WRAP); @@ -229,8 +228,7 @@ public void readFile(String filepath, Promise promise) { @ReactMethod public void read(String filepath, int length, int position, Promise promise) { - try { - InputStream inputStream = getInputStream(filepath); + try (InputStream inputStream = getInputStream(filepath)) { byte[] buffer = new byte[length]; inputStream.skip(position); int bytesRead = inputStream.read(buffer, 0, length);