Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework limit/render limit #764

Closed
AndrewSisley opened this issue Aug 29, 2022 · 0 comments · Fixed by #767
Closed

Rework limit/render limit #764

AndrewSisley opened this issue Aug 29, 2022 · 0 comments · Fixed by #767
Assignees
@AndrewSisley
Labels
area/query Related to the query component code quality Related to improving code quality refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Milestone
DefraDB v0.3.1

Comments

@AndrewSisley
Copy link
Contributor

Current code is inadequate for aggregate limits and can be greatly simplified (with likely performance boost). Instead of using render limit and hidden docs, we can have another hidden field with the limit this can work for all cases (including orig case) allowing us to have a single limit node.

Broken out from #378
@AndrewSisley AndrewSisley added area/query Related to the query component refactor This issue specific to or requires *notable* refactoring of existing codebases and components code quality Related to improving code quality labels Aug 29, 2022
@AndrewSisley AndrewSisley added this to the DefraDB v0.3.1 milestone Aug 29, 2022
@AndrewSisley AndrewSisley self-assigned this Aug 29, 2022
This was referenced Aug 29, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/query Related to the query component code quality Related to improving code quality refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Milestone
DefraDB v0.3.1
Development

Successfully merging a pull request may close this issue.

refactor: Rework limit node flow sourcenetwork/defradb
1 participant
@AndrewSisley