fix: Change output to outputpath in config file template for logger

[fredcarle]

Relevant issue(s)

Resolves #715

Description

This PR changes the config file template to have the right text for the output path of the logger.

Tasks

• I made sure the code is well commented, particularly hard-to-understand areas.
• I made sure the repository-held documentation is changed accordingly.
• I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
• I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

manual and unit tests

Specify the platform(s) on which this was tested:

• MacOS

[shahzadlone]

LGTM!

[orpheuslummis]

With defradb's configuration we can set a parameter via multiple ways: CLI flags, env variables, configuration file. One principle is to keep the param name the same across.

Here, I suggest the param is to be called output rather than outputpath because "path" is implied.

That would mean changing

defradb/cli/root.go

Line 97 in 19fd372

err = viper.BindPFlag("log.outputpath", rootCmd.PersistentFlags().Lookup("logoutput"))

to log.output

and keeping the output key in config file. It's the key in config file template that defines the env variable that is detected by viper.

[orpheuslummis]

cheers for writing the test

[codecov]

Codecov Report

Merging #716 (ccc94de) into develop (38613a5) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff            @@
##           develop     #716   +/-   ##
========================================
  Coverage    57.48%   57.48%           
========================================
  Files          143      143           
  Lines        16390    16390           
========================================
  Hits          9422     9422           
  Misses        6085     6085           
  Partials       883      883           

Impacted Files	Coverage Δ
cli/cli.go	18.75% <0.00%> (ø)
config/configfile.go	75.00% <ø> (ø)
cli/root.go	47.67% <66.66%> (ø)
config/config.go	74.60% <100.00%> (ø)

[fredcarle]

@orpheuslummis and @shahzadlone are you guys happy with the latest changes based on feedback?

[shahzadlone]

@orpheuslummis and @shahzadlone are you guys happy with the latest changes based on feedback?

LGTM

[orpheuslummis]

LGTM