Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add config and registry clearing to TestLogWritesMessagesToFeedbackLog #596

Merged
merged 1 commit into from
Jul 6, 2022
Merged

fix: Add config and registry clearing to TestLogWritesMessagesToFeedbackLog #596

merged 1 commit into from
Jul 6, 2022

Conversation

fredcarle
Copy link
Collaborator

@fredcarle fredcarle commented Jul 6, 2022 •
edited
Loading

Relevant issue(s)

Resolves #595

Description

This PR fixes an issues where the troubled test function, when running before another test function that specified an empty log path slice, would cause the config global to keep an invalid output path in memory.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Unit testing

Specify the platform(s) on which this was tested:

  • MacOS

@fredcarle fredcarle added bug Something isn't working area/logging Related to the logging/logger system action/no-benchmark Skips the action that runs the benchmark. labels Jul 6, 2022
@fredcarle fredcarle added this to the DefraDB v0.3 milestone Jul 6, 2022
@fredcarle fredcarle requested a review from a team July 6, 2022 23:09
@fredcarle fredcarle self-assigned this Jul 6, 2022
@fredcarle fredcarle merged commit 0f54d22 into develop Jul 6, 2022
@fredcarle fredcarle deleted the fredcarle/fix/I595-fix-logging-test branch July 6, 2022 23:23
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@fredcarle
fix: Add config and registry clearing to TestLogWritesMessagesToFeedb…
b125177 
…ackLog (sourcenetwork#596)

Relevant issue(s)
Resolves sourcenetwork#595

Description
This PR fixes an issues where the troubled test function, when running before another test function that specified an empty log path slice, would cause the config global to keep an invalid output path in memory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzadlone shahzadlone shahzadlone approved these changes

Assignees

@fredcarle fredcarle

Labels
action/no-benchmark Skips the action that runs the benchmark. area/logging Related to the logging/logger system bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.

TestLogWritesMessagesToFeedbackLog missing clearConfig and clearRegistry causing log path error
2 participants
@fredcarle @shahzadlone