Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update libp2p dependency to v0.19 #424

Merged
merged 3 commits into from
May 10, 2022

Conversation

orpheuslummis
Copy link
Contributor

@orpheuslummis orpheuslummis commented May 9, 2022

closes #423

in libp2p v0.18.0 go-libp2p-connmgr was merged into the main libp2p library which introduced a breaking change which is handled here.

@orpheuslummis orpheuslummis added the action/no-benchmark Skips the action that runs the benchmark. label May 9, 2022
@orpheuslummis orpheuslummis added this to the DefraDB v0.3 milestone May 9, 2022
@orpheuslummis orpheuslummis self-assigned this May 9, 2022
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orpheuslummis
Copy link
Contributor Author

NOTE: The other dependencies updated as part of this are not introducing breaking changes. We're a bit flying blind currently with this part of the codebase, until we get testing for it.

Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared a possible alternative to what you did in case you like it better.

node/options.go Outdated Show resolved Hide resolved
@orpheuslummis orpheuslummis merged commit e39deb1 into develop May 10, 2022
@orpheuslummis orpheuslummis deleted the orpheus/chore/update-libp2p-v0.19 branch May 10, 2022 15:52
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependency libp2p to v0.19
4 participants