Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use new logger in net/api #420

Merged
merged 2 commits into from
May 9, 2022
Merged

refactor: Use new logger in net/api #420

merged 2 commits into from
May 9, 2022

Conversation

orpheuslummis
Copy link
Contributor

closes #419

@orpheuslummis orpheuslummis added refactor This issue specific to or requires *notable* refactoring of existing codebases and components area/logging Related to the logging/logger system action/no-benchmark Skips the action that runs the benchmark. labels May 9, 2022
@orpheuslummis orpheuslummis self-assigned this May 9, 2022
fredcarle
fredcarle reviewed May 9, 2022
View reviewed changes
net/api/service.go Outdated Show resolved Hide resolved
net/api/service.go Outdated Show resolved Hide resolved
fredcarle
fredcarle approved these changes May 9, 2022
View reviewed changes
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

AndrewSisley
AndrewSisley approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) I thought I got them all outside the http package - my bad, and thanks for correcting

@orpheuslummis orpheuslummis merged commit 1ea959d into develop May 9, 2022
@orpheuslummis orpheuslummis deleted the orpheus/refactor/logging-netapi branch May 9, 2022 14:54
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@orpheuslummis
refactor: Use new logger in net/api (sourcenetwork#420)
e052eb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredcarle fredcarle fredcarle approved these changes

@AndrewSisley AndrewSisley AndrewSisley approved these changes

@shahzadlone shahzadlone Awaiting requested review from shahzadlone

Assignees

@orpheuslummis orpheuslummis

Labels
action/no-benchmark Skips the action that runs the benchmark. area/logging Related to the logging/logger system refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use defradb's internal logger in net/api as well
3 participants
@orpheuslummis @fredcarle @AndrewSisley