Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add bug bash tests for gql fragments #3136

Merged

Conversation

AndrewSisley
Copy link
Contributor

@AndrewSisley AndrewSisley commented Oct 15, 2024

Relevant issue(s)

Resolves #3135

Description

Adds bug bash tests for gql fragments with inner objects. No bugs found.

@AndrewSisley AndrewSisley added area/testing Related to any test or testing suite code quality Related to improving code quality priority/low labels Oct 15, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.14 milestone Oct 15, 2024
@AndrewSisley AndrewSisley requested a review from a team October 15, 2024 15:35
@AndrewSisley AndrewSisley self-assigned this Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.02%. Comparing base (6cc39a7) to head (502835a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3136      +/-   ##
===========================================
+ Coverage    80.01%   80.02%   +0.01%     
===========================================
  Files          353      353              
  Lines        28437    28437              
===========================================
+ Hits         22752    22756       +4     
+ Misses        4073     4071       -2     
+ Partials      1612     1610       -2     
Flag Coverage Δ
all-tests 80.02% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc39a7...502835a. Read the comment docs.

Copy link
Member

@nasdf nasdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional coverage!

Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was the only way I could think of that might break the feature that wasn't already covered, and it worked fine :)
@AndrewSisley AndrewSisley merged commit c549570 into sourcenetwork:develop Oct 16, 2024
42 of 43 checks passed
@AndrewSisley AndrewSisley deleted the 3135-bug-bash-gql-fragments branch October 16, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to any test or testing suite code quality Related to improving code quality priority/low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug bash tests for #3066
3 participants