refactor: Initialize database in constructor #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is more obvious
Makes it much harder to forget to initialize database (lots of functionality can partially work without doing so, leading to failures being detected later than need be)
AndrewSisley
added
the
area/db-system
Codecov Report
@@ Coverage Diff @@
## develop #211 +/- ##
===========================================
+ Coverage 57.42% 57.54% +0.12%
===========================================
Files 98 98
Lines 9616 9613 -3
===========================================
+ Hits 5522 5532 +10
+ Misses 3479 3460 -19
- Partials 615 621 +6
|
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Explicitly return nil in case of no error Is more obvious * Initialize database in constructor Makes it much harder to forget to initialize database (lots of functionality can partially work without doing so, leading to failures being detected later than need be)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #156
Makes it much harder to forget to initialize database (lots of functionality can partially work without doing so, leading to failures being detected later than need be - such as not loading existing schemas)