Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better dependency building rules, perhaps split into build-only and dev-only deps. #1707

Open
shahzadlone opened this issue Jul 25, 2023 · 0 comments
Assignees
Labels
code quality Related to improving code quality dependencies Related to dependencies

Comments

@shahzadlone
Copy link
Member

shahzadlone commented Jul 25, 2023

Better dependency building rules, perhaps split into build-only and dev-only deps.

  1. build-only deps would be like the make deps:modules rule right now

  2. dev-only deps would be deps that are needed for developers but aren't need to run defradb for example codecov tool.

  3. make:deps would be make deps:build + make deps:dev.

OR it could be that (to be more consistent with our other dep rules):

  • make deps: is all defradb build specific dependencies.
  • make deps:dev: is all defradb developer specific dependencies.
  • make deps:all: is all => make deps + make deps:dev
@shahzadlone shahzadlone added code quality Related to improving code quality dependencies Related to dependencies labels Jul 25, 2023
@shahzadlone shahzadlone added this to the DefraDB v0.7 milestone Jul 25, 2023
@shahzadlone shahzadlone self-assigned this Jul 25, 2023
@shahzadlone shahzadlone modified the milestones: DefraDB v0.7, DefraDB v0.8 Sep 14, 2023
@fredcarle fredcarle removed this from the DefraDB v0.8 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Related to improving code quality dependencies Related to dependencies
Projects
None yet
Development

No branches or pull requests

2 participants