Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Remove secret ssh key stuff from change detector wf #1438

Merged
merged 1 commit into from
May 1, 2023
Merged

ci: Remove secret ssh key stuff from change detector wf #1438

merged 1 commit into from
May 1, 2023

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #1437

Description

Removes secret ssh key stuff from change detector workflow.

@AndrewSisley AndrewSisley added area/testing Related to any test or testing suite ci/build This is issue is about the build or CI system, and the administration of it. action/no-benchmark Skips the action that runs the benchmark. labels May 1, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.5.1 milestone May 1, 2023
@AndrewSisley AndrewSisley requested a review from a team May 1, 2023 19:22
@AndrewSisley AndrewSisley self-assigned this May 1, 2023
shahzadlone
shahzadlone approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewSisley AndrewSisley changed the title test: Remove secret ssh key stuff from change detector wf ci: Remove secret ssh key stuff from change detector wf May 1, 2023
fredcarle
fredcarle approved these changes May 1, 2023
View reviewed changes
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented May 1, 2023 •
edited
Loading

Codecov Report

Merging #1438 (134529a) into develop (68a8cb6) will not change coverage.
The diff coverage is n/a.

❗ Current head 134529a differs from pull request most recent head c924418. Consider uploading reports for the commit c924418 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1438   +/-   ##
========================================
  Coverage    72.21%   72.21%           
========================================
  Files          185      185           
  Lines        18160    18160           
========================================
  Hits         13115    13115           
  Misses        4012     4012           
  Partials      1033     1033

see 1 file with indirect coverage changes

@AndrewSisley AndrewSisley force-pushed the 1437-detect-changes-secret branch 4 times, most recently from 730bd69 to 134529a Compare May 1, 2023 20:02
@AndrewSisley
Remove secret ssh key stuff from change detector wf
c924418 
No secret no longer exists and is not needed since open-sourcing
@AndrewSisley AndrewSisley merged commit 5af7bb5 into sourcenetwork:develop May 1, 2023
@AndrewSisley AndrewSisley deleted the 1437-detect-changes-secret branch May 1, 2023 21:03
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@AndrewSisley
ci: Remove secret ssh key stuff from change detector wf (sourcenetwor…
85138fb 
…k#1438)

## Relevant issue(s)

Resolves sourcenetwork#1437

## Description

Removes secret ssh key stuff from change detector workflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredcarle fredcarle fredcarle approved these changes

@shahzadlone shahzadlone shahzadlone approved these changes

Assignees

@AndrewSisley AndrewSisley

Labels
action/no-benchmark Skips the action that runs the benchmark. area/testing Related to any test or testing suite ci/build This is issue is about the build or CI system, and the administration of it.
Projects
None yet
Milestone
DefraDB v0.5.1
Development

Successfully merging this pull request may close these issues.

Detect-changes workflow references secret that no longer exists (and is not needed)
3 participants
@AndrewSisley @fredcarle @shahzadlone