Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Improve security policy #1240

Merged
merged 1 commit into from
Mar 27, 2023
Merged

docs: Improve security policy #1240

merged 1 commit into from
Mar 27, 2023

Conversation

orpheuslummis
Copy link
Contributor

Relevant issue(s)

Resolves #1239

Description

A few tweaks of the document by @addobot

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

humans

@orpheuslummis orpheuslummis added documentation Improvements or additions to documentation action/no-benchmark Skips the action that runs the benchmark. labels Mar 27, 2023
@orpheuslummis orpheuslummis added this to the DefraDB v0.5 milestone Mar 27, 2023
@orpheuslummis orpheuslummis requested a review from a team March 27, 2023 22:05
@orpheuslummis orpheuslummis self-assigned this Mar 27, 2023
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #1240 (c25a217) into develop (e66fe27) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1240      +/-   ##
===========================================
+ Coverage    70.60%   70.63%   +0.02%     
===========================================
  Files          182      182              
  Lines        17138    17138              
===========================================
+ Hits         12100    12105       +5     
+ Misses        4109     4105       -4     
+ Partials       929      928       -1

see 2 files with indirect coverage changes

AndrewSisley
AndrewSisley approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orpheuslummis orpheuslummis merged commit 23bef97 into develop Mar 27, 2023
@orpheuslummis orpheuslummis deleted the orpheus/docs/security-policy-v2 branch March 27, 2023 23:04
shahzadlone pushed a commit that referenced this pull request Apr 13, 2023
@orpheuslummis @shahzadlone
docs: Improve security policy (#1240)
84335cf
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@orpheuslummis
docs: Improve security policy (sourcenetwork#1240)
db25c4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSisley AndrewSisley AndrewSisley approved these changes

Assignees

@orpheuslummis orpheuslummis

Labels
action/no-benchmark Skips the action that runs the benchmark. documentation Improvements or additions to documentation
Projects
None yet
Milestone
DefraDB v0.5
Development

Successfully merging this pull request may close these issues.

Security policy stylistic issues
2 participants
@orpheuslummis @AndrewSisley