Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

a8n: Upsert ChangesetEvents from Bitbucket Server webhooks #6726

Closed
mrnugget opened this issue Nov 20, 2019 · 5 comments · Fixed by #7655
Closed

a8n: Upsert ChangesetEvents from Bitbucket Server webhooks #6726

mrnugget opened this issue Nov 20, 2019 · 5 comments · Fixed by #7655
Assignees
Labels
batch-changes Issues related to Batch Changes bitbucket Issues that occur with the Bitbucket Server code host
Milestone

Comments

@mrnugget
Copy link
Contributor

This the Automation/Sourcegraph side of RFC 45 - Extend Bitbucket Server Plugin.

With the webhooks added in sourcegraph/bitbucket-server-plugin#10 and their documentation added in sourcegraph/bitbucket-server-plugin#11 we can add support for Bitbucket Server webhooks to Automation.

What we need to do is the Bitbucket Server equivalent of the GitHub webhook implementation: https://github.com/sourcegraph/sourcegraph/pull/5913

@mrnugget mrnugget added bitbucket Issues that occur with the Bitbucket Server code host automation labels Nov 20, 2019
@felixfbecker felixfbecker added this to the 3.11 milestone Nov 22, 2019
@beyang
Copy link
Member

beyang commented Dec 14, 2019

Dear all,

This is your release captain speaking. 🚂🚂🚂

Branch cut for the 3.11 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly.
When in doubt, reach out!

Thank you

@mrnugget mrnugget removed this from the 3.11 milestone Dec 16, 2019
@tsenart tsenart added this to the 3.12 milestone Dec 19, 2019
@tsenart
Copy link
Contributor

tsenart commented Dec 19, 2019

@kzh: Tentatively added this to the 3.12 milestone and our tracking issue and assigned you. We'll confirm after our roadmap planning meeting today if this gets planned for 3.12 or not.

On implementation: The key difference between the equivalent GitHub implementation (in the issue description) and this one is that with Bitbucket Server, Sourcegraph should be automatically creating the webhooks via the API you created, and storing their configuration (i.e. secret, etc) in Postgres. This is in contrast with the admin creating the webhook via the GitHub UI and telling us about the secret via external service config (we don't have a UI to create those webhooks).

@tsenart
Copy link
Contributor

tsenart commented Jan 14, 2020

@kzh: There are still things to be done here, right? Documentation and creating the webhooks in particular. Any other things?

@tsenart tsenart reopened this Jan 14, 2020
@kzh
Copy link
Contributor

kzh commented Jan 15, 2020

Documentation and creating the webhooks (#7730) will close this out. There are other potential polish work (more general to the BBS SG plugin), but that is not required in 3.12.

@beyang
Copy link
Member

beyang commented Jan 16, 2020

Dear all,

This is your release captain speaking. 🚂🚂🚂

Branch cut for the 3.12 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly.
When in doubt, reach out!

Thank you

@kzh kzh closed this as completed Jan 16, 2020
@chrispine chrispine added the batch-changes Issues related to Batch Changes label Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
batch-changes Issues related to Batch Changes bitbucket Issues that occur with the Bitbucket Server code host
Projects
None yet
6 participants